GROOVY-11642: include annotations and modifiers in inner class offset#2211
Merged
Conversation
Member
Author
|
I checked field, method and compact constructor. The first two already include annotations and modifiers in their source offset and the compact constructor is mapped to a closure in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2211 +/- ##
==================================================
+ Coverage 68.9576% 68.9672% +0.0096%
- Complexity 29591 29598 +7
==================================================
Files 1423 1423
Lines 114102 114102
Branches 19793 19793
==================================================
+ Hits 78682 78693 +11
+ Misses 28800 28793 -7
+ Partials 6620 6616 -4
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AST building process to include annotations and modifiers in inner class offsets, aligning them with the outer class offset logic.
- Replaces the direct call to visitClassDeclaration with a call to configureAST to further process AST nodes for inner classes.
Files not reviewed (3)
- src/test-resources/bugs/BUG-GROOVY-8426.groovy: Language not supported
- src/test/groovy/org/apache/groovy/parser/antlr4/GroovyParserTest.groovy: Language not supported
- src/test/groovy/org/codehaus/groovy/antlr/AstBuilderTest.groovy: Language not supported
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inner class offset like outer class offset